Skip to content

refactor: Use designated initializers for ModelDimensions#2958

Merged
dweindl merged 2 commits intoAMICI-dev:mainfrom
dweindl:refactor_model_dim
Oct 3, 2025
Merged

refactor: Use designated initializers for ModelDimensions#2958
dweindl merged 2 commits intoAMICI-dev:mainfrom
dweindl:refactor_model_dim

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 3, 2025

Improves readability/maintainability.

@dweindl dweindl self-assigned this Oct 3, 2025
Improves readability/maintainability.

Also fixes the C++ standard for model building which was still lagging behind.
@dweindl dweindl force-pushed the refactor_model_dim branch from ebfc33a to 2afdf36 Compare October 3, 2025 09:20
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.59%. Comparing base (dbf0ac2) to head (0aead10).
⚠️ Report is 126 commits behind head on main.

Files with missing lines Patch % Lines
models/model_calvetti_py/model_calvetti_py.h 50.00% 1 Missing ⚠️
models/model_dirac_py/model_dirac_py.h 50.00% 1 Missing ⚠️
models/model_events_py/model_events_py.h 50.00% 1 Missing ⚠️
...odel_jakstat_adjoint_py/model_jakstat_adjoint_py.h 50.00% 1 Missing ⚠️
...ls/model_nested_events_py/model_nested_events_py.h 50.00% 1 Missing ⚠️
models/model_neuron_py/model_neuron_py.h 50.00% 1 Missing ⚠️
models/model_robertson_py/model_robertson_py.h 50.00% 1 Missing ⚠️
models/model_steadystate_py/model_steadystate_py.h 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2958      +/-   ##
==========================================
- Coverage   77.15%   76.59%   -0.56%     
==========================================
  Files         307      307              
  Lines       19933    19916      -17     
  Branches     1502     1502              
==========================================
- Hits        15379    15255     -124     
- Misses       4541     4648     +107     
  Partials       13       13              
Flag Coverage Δ
cpp 72.75% <57.89%> (+0.11%) ⬆️
cpp_python 38.30% <15.78%> (+0.04%) ⬆️
petab 39.36% <100.00%> (-0.10%) ⬇️
python 70.31% <57.89%> (-0.07%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/model_dimensions.h 100.00% <100.00%> (+54.28%) ⬆️
src/model.cpp 85.37% <100.00%> (+<0.01%) ⬆️
src/rdata.cpp 82.59% <100.00%> (+0.02%) ⬆️
models/model_calvetti_py/model_calvetti_py.h 58.02% <50.00%> (+1.06%) ⬆️
models/model_dirac_py/model_dirac_py.h 58.44% <50.00%> (+0.27%) ⬆️
models/model_events_py/model_events_py.h 65.89% <50.00%> (+1.01%) ⬆️
...odel_jakstat_adjoint_py/model_jakstat_adjoint_py.h 69.87% <50.00%> (-0.20%) ⬇️
...ls/model_nested_events_py/model_nested_events_py.h 62.89% <50.00%> (+0.71%) ⬆️
models/model_neuron_py/model_neuron_py.h 72.02% <50.00%> (ø)
models/model_robertson_py/model_robertson_py.h 53.37% <50.00%> (-0.32%) ⬇️
... and 1 more

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review October 3, 2025 11:27
@dweindl dweindl requested a review from a team as a code owner October 3, 2025 11:27
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dweindl dweindl merged commit 5a28bde into AMICI-dev:main Oct 3, 2025
16 of 18 checks passed
@dweindl dweindl deleted the refactor_model_dim branch October 3, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants