refactor: Use designated initializers for ModelDimensions#2958
Merged
dweindl merged 2 commits intoAMICI-dev:mainfrom Oct 3, 2025
Merged
refactor: Use designated initializers for ModelDimensions#2958dweindl merged 2 commits intoAMICI-dev:mainfrom
dweindl merged 2 commits intoAMICI-dev:mainfrom
Conversation
Improves readability/maintainability. Also fixes the C++ standard for model building which was still lagging behind.
ebfc33a to
2afdf36
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2958 +/- ##
==========================================
- Coverage 77.15% 76.59% -0.56%
==========================================
Files 307 307
Lines 19933 19916 -17
Branches 1502 1502
==========================================
- Hits 15379 15255 -124
- Misses 4541 4648 +107
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves readability/maintainability.