Skip to content

Remove deprecated functionality#2960

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:remove_deprecated
Oct 4, 2025
Merged

Remove deprecated functionality#2960
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:remove_deprecated

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 3, 2025

Removed all deprecated functionality in v1.0.

Removed all deprecated functionality in v1.0.
@dweindl dweindl force-pushed the remove_deprecated branch from 13a628b to 35fc9a3 Compare October 3, 2025 12:18
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.44%. Comparing base (6d0402a) to head (35fc9a3).
⚠️ Report is 127 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2960      +/-   ##
==========================================
- Coverage   77.13%   76.44%   -0.70%     
==========================================
  Files         307      307              
  Lines       19955    19929      -26     
  Branches     1508     1502       -6     
==========================================
- Hits        15393    15235     -158     
- Misses       4549     4681     +132     
  Partials       13       13              
Flag Coverage Δ
cpp 72.60% <ø> (-0.03%) ⬇️
cpp_python 38.25% <ø> (+0.06%) ⬆️
petab 39.46% <ø> (+0.05%) ⬆️
python 70.35% <ø> (-0.02%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/petab_import.py 100.00% <ø> (ø)
python/sdist/amici/petab/simulations.py 94.89% <ø> (ø)
python/sdist/amici/sbml_import.py 80.14% <ø> (-12.05%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review October 3, 2025 13:40
@dweindl dweindl requested a review from a team as a code owner October 3, 2025 13:40
@dweindl dweindl merged commit d5492c3 into AMICI-dev:main Oct 4, 2025
23 of 24 checks passed
@dweindl dweindl deleted the remove_deprecated branch October 4, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants