Skip to content

Remove amici.petab.petab_import.import_model alias.#2968

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:import_model_sbml
Oct 6, 2025
Merged

Remove amici.petab.petab_import.import_model alias.#2968
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:import_model_sbml

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 6, 2025

Remove amici.petab.petab_import.import_model which was an alias for amici.petab.petab_import.import_model_sbml for backward compatibility.

@dweindl dweindl self-assigned this Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.61%. Comparing base (5e0acb2) to head (f33bfd6).
⚠️ Report is 122 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2968      +/-   ##
==========================================
- Coverage   77.29%   76.61%   -0.68%     
==========================================
  Files         307      307              
  Lines       19912    19912              
  Branches     1502     1503       +1     
==========================================
- Hits        15391    15256     -135     
- Misses       4508     4643     +135     
  Partials       13       13              
Flag Coverage Δ
cpp 72.77% <ø> (ø)
cpp_python 38.30% <ø> (ø)
petab 39.36% <ø> (ø)
python 70.33% <ø> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/petab_import.py 100.00% <ø> (ø)
python/tests/test_petab_import.py 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Remove `amici.petab.petab_import.import_model` which was an alias for `amici.petab.petab_import.import_model_sbml` for backward compatibility.
@dweindl dweindl force-pushed the import_model_sbml branch from 601a5dc to f33bfd6 Compare October 6, 2025 13:34
@dweindl dweindl marked this pull request as ready for review October 6, 2025 14:55
@dweindl dweindl requested a review from a team as a code owner October 6, 2025 14:55
@dweindl dweindl merged commit f005fac into AMICI-dev:main Oct 6, 2025
17 of 18 checks passed
@dweindl dweindl deleted the import_model_sbml branch October 6, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants