Return amici.Model from sbml2amici, pysb2amici#2971
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Oct 31, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
==========================================
- Coverage 76.48% 75.79% -0.70%
==========================================
Files 308 308
Lines 19540 19542 +2
Branches 1500 1500
==========================================
- Hits 14945 14811 -134
- Misses 4582 4718 +136
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The import function `sbml2amici`, `pysb2amici`, and `antimony2amici` now return an instance of the generated model class if called with `compile=True` (default) avoiding the need for a separate call to `amici.import_model_module`. Closes AMICI-dev#2970.
FFroehlich
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import functions
sbml2amici,pysb2amici, andantimony2amicinow return an instance of the generated model class if called withcompile=True(default) avoiding the need for a separate call toamici.import_model_module.Closes #2970.