Merged
Conversation
dweindl
force-pushed
the
petab_v2_import
branch
2 times, most recently
from
074fdb9 to
1904851
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2974 +/- ##
==========================================
+ Coverage 76.71% 77.38% +0.67%
==========================================
Files 309 311 +2
Lines 19899 20597 +698
Branches 1497 1500 +3
==========================================
+ Hits 15265 15939 +674
- Misses 4621 4648 +27
+ Partials 13 10 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
petab_v2_import
branch
10 times, most recently
from
5ce3337 to
3b9080f
Compare
dweindl
force-pushed
the
petab_v2_import
branch
2 times, most recently
from
cfeb505 to
02ad833
Compare
dweindl
force-pushed
the
petab_v2_import
branch
14 times, most recently
from
31db7ab to
a90f960
Compare
dweindl
force-pushed
the
petab_v2_import
branch
from
374226a to
7c3536c
Compare
FFroehlich
approved these changes
Nov 7, 2025
| # compile amici model | ||
| if case.startswith("0006") and not jax: | ||
| # TODO: petab.flatten_timepoint_specific_output_overrides(problem) | ||
| # petab.flatten_timepoint_specific_output_overrides(problem) |
Member
There was a problem hiding this comment.
Other tests suggest this is now supported
| # TODO: So far, PEtab can only upgrade file-based problems, | ||
| # not petab.v1.Problem objects. | ||
| raise NotImplementedError( | ||
| "Only `petab.v2.Problem` is currently supported. " |
Member
There was a problem hiding this comment.
should this error message explicitly mention incompatibility with file based problems to avoid confusion?
| ): | ||
| target_entity.value = expr | ||
| else: | ||
| # if the target is not an expression, it must be an |
Member
There was a problem hiding this comment.
TODO: would be more efficient to convert this into a multi-model problem, but who knows whether we will ever get around to implementing that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental import of SBML- and PySB-based PEtab v2 problems.
Not particularly performant or feature-complete yet - to be extended.
Closes #2662.
👀 https://amici--2974.org.readthedocs.build/en/2974/examples/example_petab/petab_v2.html
👀 https://amici--2974.org.readthedocs.build/en/2974/generated/amici.petab.petab_importer.html#module-amici.petab.petab_importer