Speed up DEModel._collect_heaviside_roots#2977
Merged
dweindl merged 2 commits intoAMICI-dev:mainfrom Oct 15, 2025
Merged
Conversation
Avoid unnecessary repeated toposorting of `w` during `_collect_heaviside_root`. Sort and substitute only once after all roots have been collected. This saves a couple of seconds for models with heavily nested piecewise functions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
==========================================
- Coverage 76.49% 75.80% -0.70%
==========================================
Files 307 307
Lines 19991 19992 +1
Branches 1501 1500 -1
==========================================
- Hits 15293 15154 -139
- Misses 4685 4825 +140
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary repeated toposorting of
wduring_collect_heaviside_root. Sort and substitute only once after all roots have been collected. This saves a couple of seconds for models with heavily nested piecewise functions.