Skip to content

Fix failing tests - RuntimeError: Not a datatype (not a datatype)#2979

Merged
dweindl merged 2 commits intoAMICI-dev:mainfrom
dweindl:fix_h5_failures
Oct 14, 2025
Merged

Fix failing tests - RuntimeError: Not a datatype (not a datatype)#2979
dweindl merged 2 commits intoAMICI-dev:mainfrom
dweindl:fix_h5_failures

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 14, 2025

Require h5py!=3.15.

Closes #2978.

@dweindl dweindl self-assigned this Oct 14, 2025
@socket-security
Copy link

socket-security bot commented Oct 14, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedh5py@​3.15.0 ⏵ 3.14.087 -13100100100100

View full report

@dweindl dweindl marked this pull request as ready for review October 14, 2025 14:17
@dweindl dweindl requested a review from a team as a code owner October 14, 2025 14:17
@dweindl dweindl enabled auto-merge October 14, 2025 14:17
@dweindl dweindl changed the title Fix failing macos tests - RuntimeError: Not a datatype (not a datatype) Fix failing tests - RuntimeError: Not a datatype (not a datatype) Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.79%. Comparing base (63ddae2) to head (123f517).
⚠️ Report is 113 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
- Coverage   76.47%   75.79%   -0.68%     
==========================================
  Files         307      307              
  Lines       19991    19991              
  Branches     1500     1500              
==========================================
- Hits        15288    15153     -135     
- Misses       4690     4825     +135     
  Partials       13       13              
Flag Coverage Δ
cpp 71.96% <ø> (ø)
cpp_python 38.21% <ø> (ø)
petab 39.25% <ø> (ø)
python 69.53% <ø> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added this pull request to the merge queue Oct 14, 2025
Merged via the queue into AMICI-dev:main with commit 11781f5 Oct 14, 2025
17 of 18 checks passed
@dweindl dweindl deleted the fix_h5_failures branch October 14, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing macos tests - RuntimeError: Not a datatype (not a datatype)

2 participants