Fix SBML import for parameters with piecewise initial assignments#2980
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Oct 17, 2025
Merged
Fix SBML import for parameters with piecewise initial assignments#2980dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2980 +/- ##
==========================================
- Coverage 76.51% 75.79% -0.72%
==========================================
Files 307 307
Lines 19992 19991 -1
Branches 1500 1500
==========================================
- Hits 15296 15153 -143
- Misses 4683 4825 +142
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Parameters that are targets of parameter-dependent initial assignments are currently implemented as `w` expressions. Those symbols are currently not supported in event triggers. Previously, `w` symbols were only substituted in a subset of root functions, resulting in compilation failures due to undefined symbols for such models. Now `w` symbols are substituted in all trigger functions. Fixes PEtab v2 import for `Smith_BMCSystBiol2013`. Also, add `NULL` to the list of reserved symbols, fixing macro-redefinition compiler warnings when importing `Smith_BMCSystBiol2013`.
dweindl
force-pushed
the
fix_w_in_triggers
branch
from
e86a43e to
010d1da
Compare
FFroehlich
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters that are targets of parameter-dependent initial assignments are currently implemented as
wexpressions. Those symbols are currently not supported in event triggers. Previously,wsymbols were only substituted in a subset of root functions, resulting in compilation failures due to undefined symbols for such models. Nowwsymbols are substituted in all trigger functions.Fixes PEtab v2 import for
Smith_BMCSystBiol2013.Also, add
NULLto the list of reserved symbols, fixing macro-redefinition compiler warnings when importingSmith_BMCSystBiol2013.