Move fiddy-amici interface to amici#2984
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Oct 21, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
==========================================
- Coverage 76.48% 75.80% -0.69%
==========================================
Files 307 308 +1
Lines 20022 20136 +114
Branches 1500 1501 +1
==========================================
- Hits 15314 15264 -50
- Misses 4695 4859 +164
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
fiddy
branch
2 times, most recently
from
1bb3ef0 to
aac0c0c
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
dweindl
force-pushed
the
fiddy
branch
2 times, most recently
from
11be723 to
7af86eb
Compare
Fiddy (https://github.com/ICB-DCM/fiddy/), a package for finite difference methods, is used here for testing. So far, the amici-fiddy interface code was in the fiddy repository. To resolve this cyclic dependency, let's move that interface code here. Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
FFroehlich
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fiddy (https://github.com/ICB-DCM/fiddy/), a package for finite difference methods, is used here for testing. So far, the amici-fiddy interface code was in the fiddy repository. To resolve this cyclic dependency, let's move that interface code here.
The code from
fiddy.extensions.amiciis copied toamici.adapters.fiddy, and fromtests/extensions/test_amici.pytopython/tests/adapters/test_fiddy.py, cleaned up, and updated to match the changed amici API.