Skip to content

PySB events#2988

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:gh-2975-pysb-events
Nov 1, 2025
Merged

PySB events#2988
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:gh-2975-pysb-events

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 23, 2025

Add option to sneak general events into PySB-derived AMICI models.

At least for now, this is intended only for internal use, in particular for PEtab v2 handling (#2975).

@dweindl dweindl self-assigned this Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.05%. Comparing base (4360d5e) to head (a35ce7d).
⚠️ Report is 97 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2988      +/-   ##
==========================================
- Coverage   76.73%   76.05%   -0.68%     
==========================================
  Files         309      309              
  Lines       19884    19884              
  Branches     1498     1498              
==========================================
- Hits        15258    15123     -135     
- Misses       4613     4748     +135     
  Partials       13       13              
Flag Coverage Δ
cpp 72.55% <100.00%> (ø)
cpp_python 37.89% <100.00%> (+0.16%) ⬆️
petab 38.59% <0.00%> (ø)
petab_sciml 14.15% <0.00%> (ø)
python 69.37% <100.00%> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_model_components.py 91.27% <100.00%> (-1.75%) ⬇️
python/sdist/amici/pysb_import.py 94.47% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the gh-2975-pysb-events branch from ae4a104 to f60ae1e Compare October 27, 2025 07:02
Add option to sneak general events into PySB-derived AMICI models.

At least for now, this is intended only for internal use,
in particular for PEtab v2 handling.
@dweindl dweindl force-pushed the gh-2975-pysb-events branch from f60ae1e to a35ce7d Compare November 1, 2025 10:37
@dweindl dweindl linked an issue Nov 1, 2025 that may be closed by this pull request
@dweindl dweindl marked this pull request as ready for review November 1, 2025 11:27
@dweindl dweindl requested a review from a team as a code owner November 1, 2025 11:27
@dweindl dweindl added this pull request to the merge queue Nov 1, 2025
Merged via the queue into AMICI-dev:main with commit 3ada40c Nov 1, 2025
24 of 25 checks passed
@dweindl dweindl deleted the gh-2975-pysb-events branch November 1, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PySB, PEtab v2 & events

2 participants