Merged
Conversation
Ensure `Model.module` gets set during `Model.clone()`. So far, this was only set during `model_module.get_model`. Fixes unpickling of cloned Models. Also implement `ModelPtr.__reduce__` in addition to `Model.__reduce__` (AMICI-dev#2985).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
==========================================
- Coverage 76.48% 75.79% -0.70%
==========================================
Files 308 308
Lines 19540 19540
Branches 1499 1499
==========================================
- Hits 14945 14810 -135
- Misses 4582 4717 +135
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure
Model.modulegets set duringModel.clone(). So far, this was only set duringmodel_module.get_model. Fixes unpickling of cloned Models.Also implement
ModelPtr.__reduce__in addition toModel.__reduce__(#2985).