Skip to content

Fix extension re-import check for swig v4.4.0#2992

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:gh-2991-fix-re-import-check
Oct 29, 2025
Merged

Fix extension re-import check for swig v4.4.0#2992
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:gh-2991-fix-re-import-check

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 28, 2025

Extension initialization changed there. %init code is now executed each time the extension is executed, not only during the initial import.

Fixes #2991.

Extension initialization changed there. `%init` code is now executed each time the extension is executed, not only during the initial import.

Fixes AMICI-dev#2991.
@dweindl dweindl self-assigned this Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.79%. Comparing base (67f3ed6) to head (f02431b).
⚠️ Report is 101 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2992       +/-   ##
===========================================
+ Coverage   45.86%   75.79%   +29.92%     
===========================================
  Files         308      308               
  Lines       19537    19540        +3     
  Branches     1499     1500        +1     
===========================================
+ Hits         8961    14810     +5849     
+ Misses      10545     4717     -5828     
+ Partials       31       13       -18     
Flag Coverage Δ
cpp 72.89% <ø> (?)
cpp_python 38.26% <ø> (ø)
petab 38.86% <ø> (ø)
python 69.62% <ø> (+30.78%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 214 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review October 28, 2025 21:43
@dweindl dweindl requested a review from a team as a code owner October 28, 2025 21:43
@dweindl dweindl merged commit 65deb50 into AMICI-dev:main Oct 29, 2025
20 of 21 checks passed
@dweindl dweindl deleted the gh-2991-fix-re-import-check branch October 29, 2025 07:59
dweindl added a commit that referenced this pull request Nov 3, 2025
Extension initialization changed there. `%init` code is now executed each time the extension is executed, not only during the initial import.

Fixes #2991.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python/tests/test_sbml_import.py::test_import_same_model_name fails with swig 4.4.0

2 participants