Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
- Coverage 78.02% 77.38% -0.65%
==========================================
Files 311 311
Lines 20598 20584 -14
Branches 1499 1500 +1
==========================================
- Hits 16071 15928 -143
- Misses 4517 4646 +129
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
FIXME: codeprinter: print all sympy.Integers as floats. |
92f6c25 to
555b300
Compare
FFroehlich
approved these changes
Nov 11, 2025
555b300 to
e8e7d83
Compare
For spline handling, replace `mathml2sympy` by sbmlmath functions. Related to AMICI-dev#2146. Also fix potential code printing issues resulting in unintended integer division specifically for splines.
e8e7d83 to
5bc059a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For spline handling, replace
mathml2sympyby sbmlmath functions. Related to #2146.