Merged
Conversation
dweindl
reviewed
Nov 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
- Coverage 78.03% 78.01% -0.02%
==========================================
Files 311 311
Lines 20584 20584
Branches 1499 1500 +1
==========================================
- Hits 16063 16059 -4
- Misses 4511 4515 +4
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
dweindl
approved these changes
Nov 12, 2025
| ) | ||
| from .exporters.sundials.cxxcodeprinter import csc_matrix | ||
| from .import_utils import ( | ||
| from .importers.utils import ( |
Member
There was a problem hiding this comment.
Okay for now, but I'd say we should make the core symbolic code not import anything from amici.importers, only vice verse. Can be addressed when moving de_model.py.
| from toposort import toposort | ||
|
|
||
| from ...import_utils import symbol_with_assumptions | ||
| from amici.importers.utils import symbol_with_assumptions |
Member
There was a problem hiding this comment.
Similar to above, amici.exporters should not import anything from amici.importers, only from the symbolic middle layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.