Faster substitutions with smart_subs_dict#3025
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Nov 12, 2025
Merged
Conversation
Member
dweindl
commented
Nov 12, 2025
- Disable evaluation during substitution
- Use xreplace instead of subs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
==========================================
- Coverage 78.03% 77.40% -0.64%
==========================================
Files 311 311
Lines 20584 20587 +3
Branches 1499 1499
==========================================
- Hits 16063 15935 -128
- Misses 4511 4642 +131
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
For my current benchmark, this reduces the time for one Disabling evaluation during substitution may prevent simplification of some expressions during substitution, but those can be simplified later on. |
FFroehlich
approved these changes
Nov 12, 2025
* Disable evaluation during substitution * Use xreplace instead of subs For my current benchmark, this reduces the time for one `smart_subs_dict` call from over 21h (still running...) to ~12min. Disabling evaluation during substitution may prevent simplification of some expressions during substitution, but those can be simplified later on.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 12, 2025
Flatten out expressions first to avoid expensive repeated substitutions in matrices. For my current benchmark, this yields another 10x improvement compared to AMICI-dev#3025.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 12, 2025
Flatten out expressions first to avoid expensive repeated substitutions in matrices. For my current benchmark, this yields another 10x improvement compared to AMICI-dev#3025.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
Flatten out expressions first to avoid expensive repeated substitutions in matrices. For my current benchmark, this yields another 10x improvement compared to #3025.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.