Use scipy-openblas only when building the Python extension#3033
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Nov 14, 2025
Merged
Use scipy-openblas only when building the Python extension#3033dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
Fixes a flaw in `cmake/AmiciFindBLAS.cmake` that resulted in incorrectly trying to use scipy-openblas during standalone C++ builds. Now, unless explicitly requested, scipy-openblas will only be considered when building (only) the Python extension.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3033 +/- ##
==========================================
- Coverage 78.06% 77.40% -0.67%
==========================================
Files 311 311
Lines 20587 20587
Branches 1499 1499
==========================================
- Hits 16071 15935 -136
- Misses 4506 4642 +136
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaw in
cmake/AmiciFindBLAS.cmakethat resulted in incorrectly trying to use scipy-openblas during standalone C++ builds. Now, unless explicitly requested, scipy-openblas will only be considered when building (only) the Python extension.