PySB import: Replace all PySB objects by plain sympy objects when cre…#3072
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Nov 25, 2025
Merged
PySB import: Replace all PySB objects by plain sympy objects when cre…#3072dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3072 +/- ##
==========================================
- Coverage 77.74% 77.10% -0.64%
==========================================
Files 313 313
Lines 20670 20678 +8
Branches 1500 1500
==========================================
- Hits 16069 15943 -126
- Misses 4592 4726 +134
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
gh-3035-strip-pysb
branch
from
0d1270a to
9d732c5
Compare
…ating the DEModel Ensure that DEModel only contains plain `sympy.Symbol`s, no `pysb.Compmenents`. Also, consistently use `symbol_with_assumptions`. Closes AMICI-dev#3035.
dweindl
force-pushed
the
gh-3035-strip-pysb
branch
from
84a2f6b to
014aed1
Compare
FFroehlich
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ating the DEModel
Ensure that DEModel only contains plain
sympy.Symbols, nopysb.Compmenents.Also, consistently use
symbol_with_assumptions.Closes #3035.