Implement event assignments in JAX

[BSnelling]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 95.52239% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.27%. Comparing base (2b036e9) to head (c4a4166).
⚠️ Report is 46 commits behind head on main.

Files with missing lines	Patch %	Lines
python/sdist/amici/jax/model.py	89.65%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3080      +/-   ##
==========================================
+ Coverage   78.23%   78.27%   +0.03%     
==========================================
  Files         315      315              
  Lines       20478    20524      +46     
  Branches     1500     1500              
==========================================
+ Hits        16021    16065      +44     
- Misses       4448     4450       +2     
  Partials        9        9              

Flag	Coverage Δ
cpp	71.75% <86.56%> (+0.02%)	⬆️
cpp_python	37.71% <17.91%> (-0.05%)	⬇️
petab	46.54% <67.16%> (+0.05%)	⬆️
petab_sciml	13.95% <64.17%> (+0.16%)	⬆️
python	70.41% <91.04%> (+0.04%)	⬆️
sbmlsuite-jax	33.38% <88.05%> (+0.53%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
python/sdist/amici/_symbolic/de_model.py	91.92% <100.00%> (+0.06%)	⬆️
...hon/sdist/amici/importers/petab/_petab_importer.py	86.78% <ø> (ø)
...thon/sdist/amici/importers/petab/v1/sbml_import.py	97.75% <ø> (ø)
python/sdist/amici/importers/sbml/__init__.py	94.35% <100.00%> (+0.02%)	⬆️
python/sdist/amici/jax/_simulation.py	97.05% <100.00%> (+0.33%)	⬆️
python/sdist/amici/jax/ode_export.py	89.23% <100.00%> (+0.89%)	⬆️
python/sdist/amici/jax/model.py	87.50% <89.65%> (+0.49%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[FFroehlich]

Let‘s temporarily disable SalazarCavazos_MBoC2020

[FFroehlich]

@dweindl only minor changes to non-jax bits but feel free to weigh in as well

[dweindl]

Cool, thanks. Can't say much on the JAX part. The rest looks good to me, except for the x_old thing.

[dweindl]

Fine as is, but it's a bit funny that $\Delta x$ updates $y$. This might be something to harmonize at some point. Using state $y$ would also be more in line with SUNDIALS.

[BSnelling]

IIUC this is a matter of different naming conventions in different parts of the code base so shouldn't be too hard to harmonise, but I'd want to check with @FFroehlich to be sure of that.

[FFroehlich]

open to changing that, but if we do so, let's do it in a separate PR.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud