Clean up amici.sim.sundials exports#3082
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Dec 4, 2025
Merged
Conversation
dweindl
force-pushed
the
import_mm
branch
5 times, most recently
from
11813ec to
a7cf440
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3082 +/- ##
==========================================
- Coverage 78.07% 77.41% -0.66%
==========================================
Files 312 312
Lines 20494 20496 +2
Branches 1500 1500
==========================================
- Hits 16000 15868 -132
- Misses 4485 4619 +134
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
import_mm
branch
3 times, most recently
from
0ee82ef to
0c5d306
Compare
FFroehlich
approved these changes
Dec 4, 2025
* Re-export `import_model_module`. * Set `__all__` The goal should be that after having compiled a model, for most applications, the only required import for loading and simulating that model is `amici.sim.sundials`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import_model_module.__all__The goal should be that after having compiled a model, for most applications, the only required import for loading and simulating that model is
amici.sim.sundials.