Move petab v2 simulation code to amici.sim#3093
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Dec 10, 2025
Merged
Conversation
7 tasks
99df343 to
3f59a7d
Compare
Related to AMICI-dev#3041. And fix type annotations.
3f59a7d to
4ba54fc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
==========================================
- Coverage 78.17% 77.54% -0.64%
==========================================
Files 313 315 +2
Lines 20469 20472 +3
Branches 1500 1501 +1
==========================================
- Hits 16002 15875 -127
- Misses 4458 4588 +130
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3041.
And fix type annotations.