Skip to content

Fix TypeError in JAXProblem._get_measurements#3122

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_3120
Jan 28, 2026
Merged

Fix TypeError in JAXProblem._get_measurements#3122
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_3120

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jan 28, 2026

Use pandas 2.x & 3.x compatible check for string dtypes.

Fixes #3120.

@dweindl dweindl self-assigned this Jan 28, 2026
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.22%. Comparing base (ab5f225) to head (0f92644).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3122   +/-   ##
=======================================
  Coverage   78.21%   78.22%           
=======================================
  Files         315      315           
  Lines       20482    20482           
  Branches     1484     1484           
=======================================
+ Hits        16021    16023    +2     
+ Misses       4453     4451    -2     
  Partials        8        8           
Flag Coverage Δ
cpp 71.69% <100.00%> (-0.02%) ⬇️
cpp_python 37.85% <0.00%> (ø)
petab 46.56% <100.00%> (ø)
petab_sciml 13.93% <0.00%> (ø)
python 70.35% <100.00%> (+0.22%) ⬆️
sbmlsuite-jax 33.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/jax/petab.py 94.00% <100.00%> (+0.27%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Use pandas 2.x & 3.x compatible check for string dtypes.

Fixes AMICI-dev#3120.
@dweindl dweindl marked this pull request as ready for review January 28, 2026 10:50
@dweindl dweindl requested a review from a team as a code owner January 28, 2026 10:50
@dweindl dweindl requested review from BSnelling and removed request for a team January 28, 2026 10:50
@dweindl dweindl merged commit 9ede529 into AMICI-dev:main Jan 28, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError in JAXProblem._get_measurements

2 participants