Skip to content

Fix PetabSimulator._aggregate_s2llh #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 3 commits into from
Feb 24, 2026
Merged

Fix PetabSimulator._aggregate_s2llh #3125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
390bb15
Fix PetabSimulator._aggregate_s2llh
dweindl Feb 13, 2026
c11aee9
Merge branch 'main' into fix_petab2_s2llh
dweindl Feb 23, 2026
3932c9e
Merge branch 'main' into fix_petab2_s2llh
dweindl Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions python/sdist/amici/sim/sundials/petab/_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@

import amici
from amici.logging import get_logger
from amici.sim.sundials import SensitivityOrder
from amici.sim.sundials import (
RDataReporting,
SensitivityMethod,
SensitivityOrder,
)

logger = get_logger(__name__, log_level=logging.INFO)

Expand Down Expand Up @@ -719,7 +723,13 @@ def _aggregate_s2llh(
or `None` if sensitivities were not computed.
"""
# TODO: add tests
if self._solver.get_sensitivity_order() < SensitivityOrder.first:
if (
self._solver.get_sensitivity_order() < SensitivityOrder.first
or self._solver.get_sensitivity_method()
!= SensitivityMethod.forward
or self._solver.get_return_data_reporting_mode()
== RDataReporting.residuals
):
return None

if not use_fim:
Expand Down
Loading