Skip to content

maint: ruff, modernize#3131

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:reruff
Feb 25, 2026
Merged

maint: ruff, modernize#3131
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:reruff

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Feb 24, 2026

  • update ruff
  • modernize & reformat

* update ruff
* modernize & reformat
@dweindl dweindl requested a review from a team as a code owner February 24, 2026 15:46
@dweindl dweindl self-assigned this Feb 24, 2026
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.36%. Comparing base (b2699a8) to head (69c3654).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/jax/petab.py 77.77% 8 Missing ⚠️
python/sdist/amici/jax/model.py 50.00% 1 Missing ⚠️
python/sdist/amici/sim/jax/__init__.py 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3131      +/-   ##
==========================================
- Coverage   77.39%   77.36%   -0.03%     
==========================================
  Files         316      316              
  Lines       20632    20632              
  Branches     1483     1483              
==========================================
- Hits        15968    15962       -6     
- Misses       4656     4662       +6     
  Partials        8        8              
Flag Coverage Δ
cpp 70.44% <15.21%> (-0.03%) ⬇️
cpp_python 37.87% <13.04%> (ø)
petab 47.16% <78.26%> (ø)
python 68.90% <15.21%> (-0.03%) ⬇️
sbmlsuite-jax 32.81% <15.21%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/_symbolic/de_model.py 91.68% <100.00%> (ø)
...ython/sdist/amici/_symbolic/de_model_components.py 93.25% <ø> (ø)
python/sdist/amici/constants.py 100.00% <100.00%> (ø)
...hon/sdist/amici/importers/petab/_petab_importer.py 86.74% <ø> (ø)
python/sdist/amici/importers/pysb/__init__.py 94.57% <ø> (ø)
python/sdist/amici/importers/sbml/__init__.py 94.26% <ø> (ø)
python/sdist/amici/importers/sbml/splines.py 80.62% <ø> (ø)
python/sdist/amici/importers/utils.py 85.90% <100.00%> (ø)
python/sdist/amici/jax/_simulation.py 94.44% <ø> (ø)
python/sdist/amici/jax/ode_export.py 88.05% <ø> (ø)
... and 3 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added this pull request to the merge queue Feb 25, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2026
@dweindl dweindl merged commit 4efab94 into AMICI-dev:main Feb 25, 2026
33 of 34 checks passed
@dweindl dweindl deleted the reruff branch February 25, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants