Skip to content

Fix importing PetabImporter without jax and sciml extras#3141

Merged
dweindl merged 2 commits intoAMICI-dev:mainfrom
dweindl:gh-3140-importfix
Feb 27, 2026
Merged

Fix importing PetabImporter without jax and sciml extras#3141
dweindl merged 2 commits intoAMICI-dev:mainfrom
dweindl:gh-3140-importfix

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Feb 27, 2026

Closes #3140.

@dweindl dweindl changed the title Fix importing PetabImporter without jax extras Fix importing PetabImporter without jax and sciml extras Feb 27, 2026
@dweindl dweindl marked this pull request as ready for review February 27, 2026 09:12
@dweindl dweindl requested a review from a team as a code owner February 27, 2026 09:12
@dweindl dweindl enabled auto-merge February 27, 2026 09:12
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.72%. Comparing base (4e223a0) to head (cd6c8b3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
- Coverage   77.35%   76.72%   -0.64%     
==========================================
  Files         318      317       -1     
  Lines       20631    20628       -3     
  Branches     1483     1483              
==========================================
- Hits        15959    15826     -133     
- Misses       4664     4794     +130     
  Partials        8        8              
Flag Coverage Δ
cpp 70.44% <ø> (+<0.01%) ⬆️
cpp_python 37.14% <ø> (-0.67%) ⬇️
petab 47.16% <ø> (+<0.01%) ⬆️
python 68.90% <ø> (+<0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...hon/sdist/amici/importers/petab/_petab_importer.py 86.74% <ø> (ø)
python/sdist/amici/sim/jax/petab.py 68.04% <ø> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl self-assigned this Feb 27, 2026
@dweindl dweindl added this pull request to the merge queue Feb 27, 2026
Merged via the queue into AMICI-dev:main with commit 323b46b Feb 27, 2026
24 of 25 checks passed
@dweindl dweindl deleted the gh-3140-importfix branch February 28, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing amici.importers.petab.PetabImporter fails if diffrax is not installed

2 participants