Skip to content

Update logging of loglevel changes#3158

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_logging
Mar 11, 2026
Merged

Update logging of loglevel changes#3158
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_logging

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Mar 11, 2026

Since #3150, there are log messages related to changing loglevels during module imports.

I think, we only want notifications for changed loglevels for pre-existing loggers.

When we are changing the loglevel from debug to something higher, we don't want to see yet another debug message. Therefore, log after applying the new loglevel.

Since AMICI-dev#3150, there are log
messages related to changing loglevels during module imports.

I think, we only want notifications for changed loglevels for pre-existing loggers.

When we are changing the loglevel from debug to something higher,
we don't want to see yet another debug message. Therefore, log after
applying the new loglevel.
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.72%. Comparing base (22b0965) to head (c97fa1f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3158      +/-   ##
==========================================
- Coverage   77.36%   76.72%   -0.64%     
==========================================
  Files         317      317              
  Lines       20629    20631       +2     
  Branches     1483     1483              
==========================================
- Hits        15959    15829     -130     
- Misses       4662     4794     +132     
  Partials        8        8              
Flag Coverage Δ
cpp 70.45% <100.00%> (+<0.01%) ⬆️
cpp_python 37.15% <100.00%> (+<0.01%) ⬆️
petab 47.17% <100.00%> (+<0.01%) ⬆️
python 68.91% <100.00%> (+<0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/logging.py 79.72% <100.00%> (+0.56%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review March 11, 2026 09:35
@dweindl dweindl requested a review from a team as a code owner March 11, 2026 09:35
@dweindl dweindl added this pull request to the merge queue Mar 11, 2026
Merged via the queue into AMICI-dev:main with commit 33affbf Mar 11, 2026
24 of 25 checks passed
@dweindl dweindl deleted the fix_logging branch March 11, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants