Open
Conversation
Contributor
|
This PR appears to contain changes to the CUDA and OpenMP implementations as well, so those should be removed I think. Also, it would be good to purge the binary file from your branch's history so that it doesn't get permanently included in the repo's history. |
45d725c to
a414eea
Compare
Contributor
Author
|
I have made the requested changes |
4638cde to
58bf0d4
Compare
58bf0d4 to
17be517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have created an OpenACC implementation for XSBench based on the existing OpenMP Offload implementation.