Skip to content

Remove unnessesary copy for OpenMP offload#38

Open
lmarzen wants to merge 1 commit intoANL-CESAR:masterfrom
lmarzen:patch-1
Open

Remove unnessesary copy for OpenMP offload#38
lmarzen wants to merge 1 commit intoANL-CESAR:masterfrom
lmarzen:patch-1

Conversation

@lmarzen
Copy link

@lmarzen lmarzen commented Oct 29, 2024

The Inputs struct, in, is unnecessarily copied back to the host after execution of the target region.

This is minor and this fix has negligible performance improvement.

I additionally added a defaultmap(none) clause which enforces explicit data mapping at compile time, likely reducing the chance of similar oversights in the future.

I chose to map the entire struct instead of only the elements used in the target region, because it is faster in my experiments. The explanation is that copying the entire struct only initiates one HtoD memcpy call, whereas mapping each element would have initiated one for each struct element which turns out to be ~50% more expensive than copying a a few dozen extra bytes in a single memcpy call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant