Conversation
Fixes: 1. Cache data based on the files antspynet/utilities/get_antsxnet_data.py and antspynet/utilities/get_pretrained_network.py. These are what actually determine what gets downloaded. Caching on the hash of download_all_data.py will result in cache hits even if data changes. 2. Only update cache once per job. Don't do it in the build matrix. Avoids race conditions and duplicating cache jobs. 3. Specify branches in run conditions, avoids running twice on PRs 4. Build from pyproject.toml, not modified requirements.txt. This allows testing on recent python. Maybe need a separate test for requirements.txt install, if it's still needed
Tired of guessing where I can put an environment variable
Not great but something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The models and networks are too large to cache (limit 10Gb per repository), but this PR lets them be saved within a workflow using artifacts. Thus we can run a build matrix to test different python versions, without doing repeated downloads. But the artifacts aren't accessible to subsequent runs.