Skip to content

Comments

feat: Implement dedicated nearby places page with improved UI#304

Open
navaneeth0041 wants to merge 2 commits intoAOSSIE-Org:developfrom
navaneeth0041:303-enhance-nearby-places-ui-with-dedicated-page-with-features
Open

feat: Implement dedicated nearby places page with improved UI#304
navaneeth0041 wants to merge 2 commits intoAOSSIE-Org:developfrom
navaneeth0041:303-enhance-nearby-places-ui-with-dedicated-page-with-features

Conversation

@navaneeth0041
Copy link
Contributor

Description

This PR introduces a dedicated NearbyPlacesPage to replace the previously cluttered inline display of nearby places in the monument details view. The new implementation offers a significantly improved user experience with advanced filtering, search functionality, and sorting options.

  • A dedicated full-screen interface for browsing nearby places
  • Search functionality to filter places by name or address
  • Multiple sorting options (A-Z, Z-A, Distance)
  • Enhanced visual hierarchy with proper spacing and consistent styling
  • Empty state handling for better feedback when no results are found

These changes address user feedback regarding difficulty navigating and finding relevant nearby services when exploring monuments.

Fixes #303

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Testing was performed on both Android and iOS devices with various screen sizes to ensure responsive design and proper functionality:

  1. Verified that the "View All Nearby Places" button correctly navigates to the new NearbyPlacesPage
  2. Confirmed search functionality works for both place names and addresses
  3. Validated all sorting options (A-Z, Z-A, Distance) produce expected results
  4. Verified that directions functionality opens Google Maps with correct coordinates
  5. Ensured empty states display appropriately when no places are found
WhatsApp.Video.2025-03-17.at.14.35.44.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@navaneeth0041 navaneeth0041 requested a review from jddeep as a code owner March 17, 2025 09:07
@mdmohsin7
Copy link
Member

Can you pls improve the colors of the unselected chips? Grey color makes them look disabled. Maybe use another shade of white

@navaneeth0041
Copy link
Contributor Author

navaneeth0041 commented Apr 5, 2025

image

@mdmohsin7 @AyaNady17
Made the necessary change(was busy with exams, that's why this took this long. Sorry for the delay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance nearby places UI with dedicated page having sorting and searcing options

2 participants