Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a static analysis warning in the monumentCheckIn method where a local variable doc was declared but never used. By removing the unused variable, we improve code quality, reduce technical debt, and ensure adherence to Dart best practices. This fix aligns with GSOC goals of fostering clean, maintainable, and efficient codebases.
Changes:
File: lib/data/repositories/firebase_social_repository.dart
Method: monumentCheckIn
Issue: Unused doc variable when creating a check-in post.
Fix: Remove the assignment of the unused DocumentReference variable.
Before:
dart
Copy
DocumentReference doc = await _database.collection("posts").add({ ... });
After:
dart
Copy
await _database.collection("posts").add({ ... });
Impact:
✅ Eliminates static analysis warnings.
✅ Reduces clutter and improves code readability.
✅ Demonstrates attention to code quality, a key GSOC evaluation criterion.
Fixes # 344
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please include screenshots below if applicable.
Checklist:
Maintainer Checklist