Skip to content

Fix sidebar toggle props and routing warnings #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aurthitaacharya-afk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix sidebar toggle props and routing warnings #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
498e974
Update README
aurthitaacharya-afk Dec 31, 2025
fe9e137
Fix text padding and Line-height to prevent cut off text
aurthitaacharya-afk Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ PictoPy is an advanced desktop gallery application that combines the power of Ta

&nbsp;&nbsp;&nbsp;<a href="https://discord.gg/hjUhu33uAn"><img src="https://github.com/user-attachments/assets/3ed93273-5055-4532-a524-87a337a4fbba" height="40"></a>

1. First, join the **[Discord Server](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
1. First, join the **[ DISCORD SERVER ](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix markdownlint MD039 by removing spaces inside the link text.

Leading/trailing spaces inside the link text trigger the linter and should be removed.

✅ Proposed fix 
-1. First, join the **[ DISCORD SERVER ](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
+1. First, join the **[DISCORD SERVER](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
1. First, join the **[ DISCORD SERVER ](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
1. First, join the **[DISCORD SERVER](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
🧰 Tools
🪛 markdownlint-cli2 (0.20.0)

[warning] 9-9: Spaces inside link text

(MD039, no-space-in-links)

[warning] 9-9: Spaces inside link text

(MD039, no-space-in-links)

🤖 Prompt for AI Agents 
In `@README.md` at line 9, The Markdown link text contains leading/trailing spaces
("[ DISCORD SERVER ](https://discord.gg/hjUhu33uAn)"), which triggers
markdownlint MD039; remove the spaces inside the square brackets so the link
reads "[DISCORD SERVER](https://discord.gg/hjUhu33uAn)". Update the README's
link text accordingly (replace "[ DISCORD SERVER ]" with "[DISCORD SERVER]") and
keep the URL unchanged.

2. For detailed setup instructions, coding guidelines, and the contribution process, please check out our [CONTRIBUTING.md](./CONTRIBUTING.md) file.

# Architecture
Expand Down
12 changes: 12 additions & 0 deletions docs/stylesheets/extra.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,18 @@
}
}

/* fix text padding issue -prevent letters from bring cut off */
button,
input,
select,
textarea,
.md-typeset p,
.md-typeset li {
line-height : 1.5;
padding-top: 0.4rem;
padding-bottom :0.4 rem;
}

\
Comment on lines +315 to 327
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix invalid padding value and remove stray backslash.

padding-bottom :0.4 rem; is invalid (space before unit), so the rule is ignored. The standalone backslash can also disrupt parsing.

✅ Proposed fix 
 button,
 input,
 select,
 textarea,
 .md-typeset p,
 .md-typeset li {
   line-height : 1.5;
   padding-top: 0.4rem;
-  padding-bottom :0.4 rem;
+  padding-bottom: 0.4rem;
 }
 
-\
 .md-footer-meta__inner.md-grid {
🧰 Tools
🪛 Biome (2.3.13)

[error] 326-327: unexpected character \

(parse)

🤖 Prompt for AI Agents 
In `@docs/stylesheets/extra.css` around lines 315 - 327, The CSS rule for form
controls and .md-typeset elements has an invalid value and stray character:
change the "padding-bottom :0.4 rem;" declaration to "padding-bottom: 0.4rem;"
and normalize spacing (e.g., "line-height: 1.5; padding-top: 0.4rem;
padding-bottom: 0.4rem;") in the selector block (button, input, select,
textarea, .md-typeset p, .md-typeset li) and remove the stray backslash at the
end of the file so the stylesheet parses correctly.

.md-footer-meta__inner.md-grid {
display: flex !important;
Expand Down