-
Notifications
You must be signed in to change notification settings - Fork 345
Fix hero description text overlap on medium screens #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix hero description text overlap on medium screens #546
Conversation
|
@rahman-D3V is attempting to deploy a commit to the AOSSIE Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughRefactors the homepage JSX layout and responsive classes to adjust hero/background positioning, explicit responsive heights, typography, and spacing to prevent decorative background overlap on medium screens; restructures button and counts blocks and removes the final Banner render. No exported API changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/pages/index.jsx`:
- Around line 36-39: The Tailwind height utility in the className on the
top-right background div is missing a unit so `lg:h-[650]` is ignored; update
the className on that div (the element with className starting " absolute
right-0 top-[-230px]...") to use an explicit unit, e.g. replace `lg:h-[650]`
with `lg:h-[650px]` so the large breakpoint height is applied correctly.
🧹 Nitpick comments (1)
src/pages/index.jsx (1)
57-57: Simplify the dark mode text color class.The arbitrary value
dark:text-[rgb(161 161 170/var(--tw-text-opacity))]relies on--tw-text-opacitybeing set, but Tailwind doesn't automatically set this CSS variable when using arbitrary color values. This could cause the color to not render as expected.Consider using the built-in utility
dark:text-zinc-400, which produces the same color (rgb 161, 161, 170) and handles opacity correctly.♻️ Proposed fix
- <p className="dark:text-[rgb(161 161 170/var(--tw-text-opacity))] mt-8 font-mono text-xl leading-7 text-zinc-600 md:dark:text-[`#FED41E`]"> + <p className="mt-8 font-mono text-xl leading-7 text-zinc-600 dark:text-zinc-400 md:dark:text-[`#FED41E`]">
|
@rahman-D3V whats ur status is it approved? |
|
Thanks for the fix! I originally reported this issue (#544). |
I guess not yet |
What was fixed
The hero section description text was overlapping with the yellow decorative background at medium screen widths, reducing readability.
Cause
The decorative background is absolutely positioned, and at the
mdbreakpoint the text container did not have sufficient spacing to avoid overlap.Fix.overlap.mp4
Related issue
Fixes #544
Summary by CodeRabbit
Style
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.