Skip to content

Remove duplicate media query for timeline lines #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prashantkumarniraj wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove duplicate media query for timeline lines #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a22c5a
Fix conflicting Tailwind CSS utility classes on About page
prashantkumarniraj Feb 1, 2026
b9868c9
Update Twitter icon to X logo
prashantkumarniraj Feb 2, 2026
96e562b
Fix footer mail icon to use mailto link
prashantkumarniraj Feb 3, 2026
0757c9a
Fix landing page email icon to open mail client
prashantkumarniraj Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 32 additions & 12 deletions src/components/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Link from 'next/link'
import { Container } from '@/components/Container'
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
import { faEnvelope } from '@fortawesome/free-solid-svg-icons'
import { faDiscord, faGithub, faGitlab, faTwitter } from '@fortawesome/free-brands-svg-icons'
import { faDiscord, faGithub, faGitlab, faXTwitter } from '@fortawesome/free-brands-svg-icons'

function NavLink({ href, children }) {
return (
Expand Down Expand Up @@ -33,20 +33,40 @@ export function Footer() {
© 2016-2025 AOSSIE. All rights reserved.
</p>
<div className="flex gap-6">
<Link aria-label="Contact by Mail" className=' text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='mailto:aossie.oss@gmail.com'>
<FontAwesomeIcon icon={faEnvelope} size='xl' />
<a
aria-label="Contact by Mail"
className="text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition"
href="mailto:aossie.oss@gmail.com"
>
<FontAwesomeIcon icon={faEnvelope} size="xl" />
</a>
<Link
aria-label="Follow on GitLab"
className="text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition"
href="https://gitlab.com/aossie"
>
<FontAwesomeIcon icon={faGitlab} size="xl" />
</Link>
<Link aria-label="Follow on GitLab" className=' text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://gitlab.com/aossie'>
<FontAwesomeIcon icon={faGitlab} size='xl' />
<Link
aria-label="Follow on GitHub"
className="text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition"
href="https://github.com/AOSSIE-Org"
>
<FontAwesomeIcon icon={faGithub} size="xl" />
</Link>
<Link aria-label="Follow on GitHub" className=' text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://github.com/AOSSIE-Org'>
<FontAwesomeIcon icon={faGithub} size='xl' />
<Link
aria-label="Join on Discord"
className="text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition"
href="https://discord.gg/hjUhu33uAn"
>
<FontAwesomeIcon icon={faDiscord} size="xl" />
</Link>
<Link aria-label="Join on Discord" className=' text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://discord.gg/hjUhu33uAn'>
<FontAwesomeIcon icon={faDiscord} size='xl' />
</Link>
<Link aria-label="Follow on Twitter" className=' text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://twitter.com/aossie_org'>
<FontAwesomeIcon icon={faTwitter} size='xl' />
<Link
aria-label="Follow on Twitter"
className="text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition"
href="https://twitter.com/aossie_org"
>
<FontAwesomeIcon icon={faXTwitter} size="xl" />
</Link>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/about.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export default function About() {
</Head>

<section style={styles.section}>
<h1 style={{ marginBottom: '20px' }} className="font-mono text-6xl font-extrabold tracking-tighter text-[#32a852] dark:text-yellow-400 sm:text-6xl md:text-5xl lg:text-6xl">
<h1 style={{ marginBottom: '20px' }} className="font-mono text-6xl font-extrabold tracking-tighter text-[#32a852] dark:text-yellow-400 md:text-5xl lg:text-6xl">
ABOUT
</h1>
Comment on lines +146 to 148
Copy link

@coderabbitai coderabbitai bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Non-monotonic responsive font sizing — heading is largest on mobile.

With text-6xl md:text-5xl lg:text-6xl, the base (mobile) size is 6xl, which then shrinks to 5xl at the md breakpoint before returning to 6xl at lg. This is an unusual pattern where the heading is paradoxically largest on the smallest screens. Was the removal of sm:text-6xl intentional here, or should the base size be reduced (e.g., text-4xl or text-5xl) so that mobile renders a smaller heading?

🤖 Prompt for AI Agents 
In `@src/pages/about.jsx` around lines 146 - 148, The h1 currently uses
non-monotonic Tailwind sizes ("text-6xl md:text-5xl lg:text-6xl") causing the
heading to be largest on mobile; update the className on the H1 element (the
ABOUT heading) to use a monotonic scale such as "text-4xl md:text-5xl
lg:text-6xl" or add an sm breakpoint (e.g., "text-5xl sm:text-6xl md:text-5xl
lg:text-6xl") depending on the intended design so mobile is not the
largest—locate the H1 with className containing text-6xl and adjust the size
tokens accordingly.

<p className="text-zinc-600 dark:text-zinc-400 text-lg font-mono leading-7">
Expand Down Expand Up @@ -179,7 +179,7 @@ export default function About() {
}}
>
<div className='m-3 w-[60px] h-[60px] bg-cover bg-[url("/contribution.png")] dark:bg-[url("/contribution-dark.png")]'></div>
<h1 className="font-mono text-2xl md:text-6xl font-extrabold tracking-tighter text-[#32a852] dark:text-yellow-400 sm:text-6xl md:text-5xl lg:text-6xl">
<h1 className="font-mono text-2xl font-extrabold tracking-tighter text-[#32a852] dark:text-yellow-400 sm:text-6xl lg:text-6xl">
GSOC CONTRIBUTION
</h1>
</div>
Expand Down
18 changes: 9 additions & 9 deletions src/pages/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
faDiscord,
faGithub,
faGitlab,
faTwitter,
faXTwitter,
} from '@fortawesome/free-brands-svg-icons'
import { CardEffect } from '@/components/CardEffect'
import { Banner } from '@/components/Banner'
Expand Down Expand Up @@ -59,13 +59,13 @@ export default function Home() {
achieve innovation and education.
</p>
<div className="mt-6 ml-4 flex gap-6">
<Link
aria-label="Contact by Mail"
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
href="mailto:aossie.oss@gmail.com"
>
<FontAwesomeIcon icon={faEnvelope} size="2xl" />
</Link>
<a
aria-label="Contact by Mail"
href="mailto:aossie.oss@gmail.com"
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
>
<FontAwesomeIcon icon={faEnvelope} size="2xl" />
</a>
<Link
aria-label="Follow on GitLab"
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
Expand All @@ -92,7 +92,7 @@ export default function Home() {
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
href="https://twitter.com/aossie_org"
>
<FontAwesomeIcon icon={faTwitter} size="2xl" />
<FontAwesomeIcon icon={faXTwitter} size="2xl" />
</Link>
</div>
<div className="mt-12 mx-4 md:mx-0 md:mt-8 text-left ">
Expand Down