Open
Conversation
Rossnkama
reviewed
Feb 15, 2023
|
|
||
| describe('Api Add Permission Params type', () => { | ||
| test('type can be instantiated', () => { | ||
| expect(isApiAddPermissionParams(aapp)).toBeTruthy() |
There was a problem hiding this comment.
These instantiation tests aren't needed, they don't any functionality
| @@ -0,0 +1,7 @@ | |||
| import { callApiNewUserWithToken } from './newUserWithToken' | |||
There was a problem hiding this comment.
Let's drop the unimplemented tests, they make it hard to spot the changes
| 'provider' in obj && | ||
| obj.provider === 'custodial' | ||
| ) | ||
| } |
| ) | ||
| } | ||
|
|
||
| const anuwtp: ApiNewUserWithTokenParams = { |
There was a problem hiding this comment.
Can you expand these variable names out
| provider: null, | ||
| } | ||
|
|
||
| describe('Api New User With Token Params type', () => { |
There was a problem hiding this comment.
This is checking that a constant you defined satisfies the same constant shape you defined in the helper which will always return true. So this test doesn't test any functionality, can you remove it?
| } | ||
|
|
||
| describe('Api New User With Token Body Params', () => { | ||
| test('type can be instantiated', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.