Open
Conversation
When cross-compiling, tool names may differ from "gcc" and "ar". Do not overwrite $(CC) if set; call the archiver via $(AR). Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Makefile suggested that the library should only be used from the build directory, which currently must be the same as the source directory. Add "install" make target and handle convenient variables: * PREFIX (default: /usr/local) * INCLUDEDIR (relative to PREFIX, default: include) * LIBDIR (relative to PREFIX, default: lib) There is no need to use this target to continue using the library from the build directory, but it saves work for users and packagers. Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
The file for pkg-config was generated line-by-line in Makefile. This required escaping and was developer-unfriendly. Generate the .pc file from a template file using awk (which is already used and must be on all POSIX-compliant systems). While there, alter the target name for the .pc file so that it is not needlessly rebuilt. Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Contributor
|
Hi and thanks. I will have to take a look at this. We currently do not have a contributor's agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to share changes I had to make to build a cross-compilation environment using Nix package manager. The last commit is optional.