Conversation
douglas-raillard-arm
changed the title
douglas-raillard-arm
left a comment
douglas-raillard-arm
left a comment
There was a problem hiding this comment.
Please reword the commit message as well to match the style normally used in that repo
could you suggest what the message should be? currently i have put it as just "add pyproject.toml". should it be elaborated more? |
address ARM-software#702 Fix the pip warning explained here: pypa/pip#11457 By following this procedure: pypa/pip#11457 (comment)
| @@ -0,0 +1,5 @@ | |||
| [build-system] | |||
| requires = [ | |||
| "setuptools>=80.9.0", | |||
There was a problem hiding this comment.
setuptools 80.9.0 require a higher version than devlib:
Requires: Python >=3.9
https://pypi.org/project/setuptools/80.9.0/
However, I'm not so sure devlib actually works with 3.7 anymore, and Ubuntu 20.04 (focal) has reached EOL earlier this year. So the next LTS is Jammy 22.04, which ships Python 3.10.
As a result, I think it's acceptable to bump the required Python version in devlib to 3.9 at least. I think this was discussed on another PR but I can't remember which one.
@marcbonnici Any thoughts ?
2 participants
Add a pyproject.toml to devlib.
Since pyproject.toml doesnt directly support dynamic versioning, added only [build-system] section so that tools like pip will refer back to setup.py to install the core of the project
So currently, this has to be used in conjunction with setup.py.
In the future, we can look into fully migrating to a pyproject.toml only approach, but that involves more things to handle versioning.
Fixes #702