This repository was archived by the owner on Jan 15, 2026. It is now read-only.
ssh: Fix connection timeout handling#726
Open
douglas-raillard-arm wants to merge 1 commit intoARM-software:masterfrom
Open
ssh: Fix connection timeout handling#726douglas-raillard-arm wants to merge 1 commit intoARM-software:masterfrom
douglas-raillard-arm wants to merge 1 commit intoARM-software:masterfrom
Conversation
Collaborator
Author
|
So after more testing, that fixes the problem when the target has a working network stack and SSH not running (or starting up), but it does not fix it if the board is just disconnected (e.g. very early boot). I'll see how to deal with that and update the PR |
e8de79b to
ccf952d
Compare
Collaborator
Author
|
PR updated with manual timeout logic. This was needed as no paramiko SshClient parameter seems to be able to delay exceptions in case the host is not available at all (e.g. not booted yet). |
Pass the timeout also as paramiko.SshClient(banner_timeout=...) parameter so that we don't get the following exception too early: SSH logic error: Error reading SSH protocol banner Also fix the case where the target hostname is not even available (e.g. very early boot before the network stack has been started).
ccf952d to
fc0d03a
Compare
Collaborator
Author
|
There still seems to be some cases not covered when devlib tries connecting before the target has been booted (before the network stack is up and running): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the timeout also as paramiko.SshClient(banner_timeout=...) parameter so that we don't get the following exception too early:
SSH logic error: Error reading SSH protocol banner
Fixes #725