Skip to content

feat: Space Bar Progression (Video Fields) #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbolles merged 4 commits into from
Jun 16, 2025
Merged

feat: Space Bar Progression (Video Fields) #107

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ff8642
Start work on key down
cbolles Jun 16, 2025
6004e25
Add ref to handle the current state
cbolles Jun 16, 2025
c48d906
Add in automatic progression through recording
cbolles Jun 16, 2025
dfbcca5
Fix formatting
cbolles Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/client/src/components/tag/videorecord/VideoRecordField.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ const VideoRecordField: React.FC<ControlProps> = (props) => {
const client = useApolloClient();
const { tag } = useTag();
const { t } = useTranslation();
const recordingRef = useRef<boolean>(recording);
recordingRef.current = recording;

const resetState = () => {
if (!props.uischema.options?.minimumRequired) {
Expand Down Expand Up @@ -105,6 +107,12 @@ const VideoRecordField: React.FC<ControlProps> = (props) => {
setVideoFragmentID(updatedVideoFragmentID);
props.handleChange(props.path, updatedVideoFragmentID);
}

// Automatic progression
const activeIndex = stateRef.current?.activeIndex;
if (activeIndex !== undefined && activeIndex != validVideos.length - 1) {
setActiveIndex(activeIndex + 1);
}
};

/** Store the blob and check if the video needs to be saved */
Expand All @@ -129,6 +137,22 @@ const VideoRecordField: React.FC<ControlProps> = (props) => {
setValidVideos(updateValidVideos);
};

// Support for using the space key to progress
const handleKeyDown = (e: KeyboardEvent) => {
if (e.key == ' ') {
// Toggle the recording state
setRecording(!recordingRef.current);
}
};

useEffect(() => {
// Listen for spaces
document.addEventListener('keydown', handleKeyDown);
return () => {
document.removeEventListener('keydown', handleKeyDown);
};
}, []);

return (
<Accordion defaultExpanded>
<AccordionSummary expandIcon={<ExpandMore />}>
Expand Down