Add exotic scales from DistingNT Soma sequencer#412
Draft
rjsmith wants to merge 1 commit intoATOVproject:developfrom
Draft
Add exotic scales from DistingNT Soma sequencer#412rjsmith wants to merge 1 commit intoATOVproject:developfrom
rjsmith wants to merge 1 commit intoATOVproject:developfrom
Conversation
Collaborator
Author
|
btw - I experimented with disabling the cargo fmt parsing on this block of code, it seems useful to see all the scales lined up... |
04a8fcc to
7720241
Compare
Contributor
|
In this PR #432 I added a display of the keyboard keys in the scale. I think this will open up to having more scales. |
Member
|
I'm just wondering whether we should keep the colors for the first 16 ones. It's easier to distinguish and has a good mapping to the configurator. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 11 more scales to the global list, ported from the Soma sequencer https://github.com/thorinside/soma/blob/main/soma.lua#L8-L29
refs #411
NB: Quote from Chris | ATOV: