Open
Conversation
chmanie
reviewed
Mar 2, 2026
Member
There was a problem hiding this comment.
Not sure if all of these changes should be in this commit?
chmanie
reviewed
Mar 2, 2026
chmanie
reviewed
Mar 2, 2026
faderpunk/src/apps/clk_div_plus.rs
Outdated
| midi_channel: MidiChannel::from_value(values[0]), | ||
| note: MidiNote::from_value(values[1]), | ||
| gatel: i32::from_value(values[2]), | ||
| division_mode: usize::from_value(values[3]).min(2), |
Member
There was a problem hiding this comment.
This is a bit weird, I'm not sure what the goal of this is. Let's figure out a better way for this.
chmanie
reviewed
Mar 2, 2026
| } | ||
|
|
||
| /// Rescale a 12-bit value (`0..=4095`) into a `min..=max` interval. | ||
| pub fn rescale_12bit_int(input: u16, min: u16, max: u16) -> u16 { |
Member
There was a problem hiding this comment.
Weren't these also added in the other PR? I'm a bit confused
ArthurGibert
force-pushed
the
feat/clock_div_plus
branch
from
209de4a to
f15afb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clock div app with assignable CV input