feat(faderpunk): flash scene LED when clock is running#471
Open
feat(faderpunk): flash scene LED when clock is running#471
Conversation
chmanie
force-pushed
the
feat/clock-led-blink
branch
from
63f9ac7 to
3482224
Compare
chmanie
changed the title
chmanie
force-pushed
the
feat/clock-led-blink
branch
from
3482224 to
74ba1d8
Compare
Contributor
|
Generally it works well but I think I preferred the way it looked before. A 1ppqn flash at Maybe we can have length and high and low luminosity as arguments to the effect to tune this The idea of having the resolution as an argument was to be able to use the same effect in the apps to display resolutions. (which I ended up not doing so I don't think it's critical we go this way) |
ArthurGibert
force-pushed
the
feat/clock-led-blink
branch
from
8b7c556 to
46fa0b5
Compare
ArthurGibert
approved these changes
Mar 6, 2026
Contributor
ArthurGibert
left a comment
ArthurGibert
left a comment
There was a problem hiding this comment.
Looks nice! I like it!
I just fixed a typo that was causing a compile issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes parts of #460. Flashes the scene button like a metronome when the clock is running.