fix(clock): improve clock out for consistent order#473
Open
ArthurGibert wants to merge 1 commit intomainfrom
Open
fix(clock): improve clock out for consistent order#473ArthurGibert wants to merge 1 commit intomainfrom
ArthurGibert wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the context for this.
When I'm using a clock out with a long division (1 bar or up) to reset the sequencers in my system at regular interval. Sometimes the longer division would be sent before or after the 4ppqn clock pulse. That is causing the sequences to misalign in an unpredictable manner (which is not great when playing live.
This PR makes sure the longer divisions (1bar and up) are sent before the shorter ones.