-
Notifications
You must be signed in to change notification settings - Fork 14
Changed the basic workflow #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
zhechengyin
commented
Jun 19, 2025
- Including the change in autoeis package (print_inference)
- Adding the example workflow with Posterior Distribution Detection (helper functions list in Wenda's commit)
- Including the change in autoeis package (print_inference) - Adding the example workflow with Posterior Distribution Detection (helper functions list in Wenda's commit)
|
@zhechengyin Thanks for the PR. I've made some comments under "Files changed" |
ma-sadeghi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Here are my comments:
print_inference_resultsneeds to be moved to the code base, currently, it's defined in the notebook.helper_functionsseem to not have been uploaded, I can only see the changed notebook under "Files changed"
… with helper functions for workflow
|
Thanks for the comments:
|
|
Just added copilot as reviewer as well - just curious about trying it out and see how it performs |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request integrates posterior distribution quality evaluation into the AutoEIS workflow by adding new columns to the circuit inference results table and providing helper functions for posterior score calculation.
- Adds three new columns to the inference results display: "Posterior Score", "Posterior Score Rank", and "Bad Parameters"
- Changes WAIC column ordering to prioritize magnitude/phase over real/imaginary values
- Introduces helper functions for evaluating posterior distribution quality and updating circuit DataFrames with scoring metrics
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/autoeis/visualization.py | Updates print_inference_results to display new posterior evaluation columns and reorders WAIC columns |
| examples/helper_function/update_circuits_info.py | Adds function to integrate posterior scoring into circuits DataFrame with ranking logic |
| examples/helper_function/evaluate_posterior_distribution.py | Implements posterior distribution evaluation with peak detection, scoring, and optional plot generation |