Skip to content

updated protocol to https #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshbafna wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated protocol to https #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws-parallelcluster-node-master/src/nodewatcher/nodewatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def _get_metadata(metadata_path):
:return the metadata value.
"""
try:
metadata_value = requests.get("http://169.254.169.254/latest/meta-data/{0}".format(metadata_path)).text
metadata_value = requests.get("https://169.254.169.254/latest/meta-data/{0}".format(metadata_path)).text
Copy link
Contributor

@bugbust-beta bugbust-beta Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Do not hardcode IP addresses because they aren't always static and might change. It also makes them vulnerable to attacks like denial of service and IP spoofing to bypass security checks. We recommend that you use environment variables or configuration files to make the IP address configurable.

Learn more

except Exception as e:
error_msg = "Unable to get {0} metadata. Failed with exception: {1}".format(metadata_path, e)
log.critical(error_msg)
Expand Down