Add $crc32() function for CRC-32 checksum computation#101
Draft
Add $crc32() function for CRC-32 checksum computation#101
Conversation
- Add CRC FunctionMapping in ir_data.py - Add $crc32 token to tokenizer.py - Add $crc32 function parsing in module_ir.py - Add $crc32 type checking in type_check.py - Add $crc32 expression bounds computation in expression_bounds.py - Add $crc32 code generation in header_generator.py - Add C++ CRC32 implementation in emboss_crc.h - Include emboss_crc.h in emboss_cpp_util.h - Add $crc32 to format_emb.py formatter - Update grammar.md with new function - Regenerate cached_parser.py - Add __init__.py to generated directory - Add test cases in module_ir_test.py and format test files Co-authored-by: AaronWebster <3766083+AaronWebster@users.noreply.github.com>
- Remove trailing whitespace from expression_bounds.py docstring - Add performance note to emboss_crc.h CRC32 implementation Co-authored-by: AaronWebster <3766083+AaronWebster@users.noreply.github.com>
- Add $crc32() function documentation - Add $crc32 to operators precedence list Co-authored-by: AaronWebster <3766083+AaronWebster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add built-in support for CRC and checksum functions
Add $crc32() function for CRC-32 checksum computation
Dec 3, 2025
Owner
|
@copilot wright unit tests for the CRC implementation |
- Add emboss_crc_test.cc with comprehensive tests for the Crc32 function - Test empty input, known test vectors (e.g., "123456789" -> 0xCBF43926) - Test single bytes, multi-byte sequences, and longer messages - Test lookup table correctness - Add test target to BUILD file Co-authored-by: AaronWebster <3766083+AaronWebster@users.noreply.github.com>
Author
Added unit tests for the CRC-32 implementation in commit 457af49. The tests cover:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.