Add static IntrinsicSizeInBytes(parameters) for parameter-dependent struct sizes#111
Draft
Add static IntrinsicSizeInBytes(parameters) for parameter-dependent struct sizes#111
Conversation
…r-dependent size Co-authored-by: AaronWebster <3766083+AaronWebster@users.noreply.github.com>
Co-authored-by: AaronWebster <3766083+AaronWebster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add static IntrinsicSizeInBytes for struct size computation
Add static IntrinsicSizeInBytes(parameters) for parameter-dependent struct sizes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For dynamically-sized structs where size depends only on parameters (not field values), users currently must instantiate a view to compute size. This adds a static
IntrinsicSizeInBytes(params...)function to compute size from parameters alone.Changes
header_generator.py:
_expression_only_depends_on_parameters()- detects if size expression uses only parameters/constants_StaticParameterFieldRenderer- renders parameter refs as function args instead of view accessors_generate_static_size_from_parameters()- generates the static function when applicablegenerated_code_templates: Added declaration/definition templates for static parameterized size function
parameters_test.cc: Test coverage for
Axes::IntrinsicSizeInBytes()Example
Generated:
Only generated when size depends solely on parameters—structs with constant size or field-dependent size are unchanged.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
releases.bazel.build/usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 version(dns block)www.googleapis.com/usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 test //compiler/back_end/cpp/testcode:parameters_test --test_output=errors(dns block)/usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 version(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.