Convert Travis CLI AppImage Build Script to GitHub Actions Script#5
Convert Travis CLI AppImage Build Script to GitHub Actions Script#5khemarato wants to merge 5 commits intoAbs62:masterfrom
Conversation
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
@Abs62 - This "on" section tells GitHub when to run this build. Right now I have it set to run "when a maintainer asks for it" ("workflow_dispatch") and when "master" branch is pushed. You can also set it up to run on pull requests, new releases, etc. See the full set of triggering option here: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows
vedgy
left a comment
vedgy
left a comment
There was a problem hiding this comment.
Have you tested the built AppImage?
Would be nice if someone else tested it as well. Maybe ask for feedback in a comment to goldendict#1594.
| sudo apt-get -y install git pkg-config build-essential qt5-qmake \ | ||
| libvorbis-dev zlib1g-dev libhunspell-dev x11proto-record-dev \ | ||
| qtdeclarative5-dev libqtwebkit-dev libxtst-dev liblzo2-dev libbz2-dev \ | ||
| qtdeclarative5-dev qtwebengine5-dev libxtst-dev liblzo2-dev libbz2-dev \ |
There was a problem hiding this comment.
QtWebEngine is not a dependency of GoldenDict master, only of goldendict#1542. So I do not think it should be here. libqtwebkit-dev probably refers to the Qt4 WebKit, so it isn't needed either. libqt5webkit5-dev (below) is sufficient.
There was a problem hiding this comment.
Does installing the unnecessary dependency qtwebengine5-dev affect the resulting AppImage in any way? If not, I guess it can remain so that goldendict#1542 does not need to be adjusted.
There was a problem hiding this comment.
Correct. apt-get install here only effects the image of the machine that builds the AppImage. It doesn't effect the AppImage itself at all.
|
Yep! Been running it the last couple days with no issues 😊 |
2 participants
This PR fixes #3 (and, presumably, goldendict#905) by converting the old Travis CI Build into a GitHub Action Script.
You can see the GitHub Action successfully ran here: https://github.com/khemarato/goldendict/actions/runs/17117255726