Allow subsurface_radius_scale to go above 1#268
Open
peterkutz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
Allow subsurface_radius_scale to go above 1#268peterkutz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
peterkutz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Contributor
|
Should this change target a fix or a feature branch ? And is not that redundant with subsurface_radius ? |
Contributor
|
I'm not sure I'm comfortable with the idea of this PR. Currently the It seems a bit unintuitive to allow for arbitrarily high HDR color components, since then the resulting "color" will generally have no relation to the color seen in the render. It's also redundant with the current functionality, and doesn't seem much of a convenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the upper bound on the supported range of values for
subsurface_radius_scale. This lets this parameter be used to decrease the volume density, not just increase it.