-
Notifications
You must be signed in to change notification settings - Fork 197
Move out python packages installations from make_python and make_pyside6 #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cedrik-fuoco-adsk
wants to merge
26
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
cedrik-fuoco-adsk:cleanup-make-python
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move out python packages installations from make_python and make_pyside6 #1030
cedrik-fuoco-adsk
wants to merge
26
commits into
AcademySoftwareFoundation:main
from
cedrik-fuoco-adsk:cleanup-make-python
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Nelson <roger.nelson@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…ython outside of make_python.py Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
60c3721 to
322f330
Compare
Signed-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com>
…ecause certifi was moved outside of make_python.py Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…cakges like cpython, meson, ninja, etc from source Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
bernie-laberge
approved these changes
Dec 19, 2025
Contributor
bernie-laberge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @cedrik-fuoco-adsk !
rogernelson
approved these changes
Dec 19, 2025
Contributor
rogernelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup, I really only have one somewhat minor suggestion around the binary component package building,
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
rogernelson
approved these changes
Dec 19, 2025
eloisebrosseau
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move out python packages installations from make_python and make_pyside6
Linked issues
n/a
Summarize your change.
Changes:
I changed pip install strategy from --no-binary :all: --only-binary pip,setuptools,wheel to --no-binary opentimelineio,numpy,PyOpenGL-accelerate,cryptography,pydantic,cffi.
Note: cffi was added because of Windows and the debug build.
Previously:
Forced all packages (except pip/setuptools/wheel) to build from source, including build tools (Cython, meson-python, ninja), pure Python packages (certifi, six, packaging, requests), and packages with native extensions
Now:
Only packages with C/C++/Rust extensions that need to link against our custom Python build are compiled from source. All other packages (build tools, pure Python libraries) use pre-built binary wheels
Rationale:
Build tools like Cython don't need to match our Python's ABI. They're just tools used during compilation. Pre-built wheels work fine and install much faster. Only runtime dependencies with native code that links to Python (like numpy's C extensions or cryptography's Rust/C code) need to be built against our specific Python build
Describe the reason for the change.
It was not clear why some package were installed in the
requirements.txt, or inmake_python.pyor at both places.I think it will be more robust like this and more clear.
Describe what you have tested and on which operating system.
MacOS + CI
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.