fix: Eliminate all warnings with minimal changes#3
Open
peter-jerry-ye wants to merge 1 commit intoAdUhTkJm:mainfrom
Open
fix: Eliminate all warnings with minimal changes#3peter-jerry-ye wants to merge 1 commit intoAdUhTkJm:mainfrom
peter-jerry-ye wants to merge 1 commit intoAdUhTkJm:mainfrom
Conversation
- Replace deprecated @math.minimum with @cmp.minimum - Replace deprecated @bytes.View with BytesView - Replace deprecated reinterpret_as_float() with Float::reinterpret_from_int() - Replace deprecated typealias/traitalias syntax with using statement - Replace deprecated to_le_bytes() with manual byte extraction - Replace deprecated size() with length() - Replace deprecated String.char_at() with code_unit_at() - Fix anti-pattern in lexer.mbt: replace try? match with try...catch...noraise - Remove unused Endianness enum variants (Little, Unspecified) and convert to Bool type - Remove unused derive(Show) from Spec struct All tests pass with no warnings. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests pass with no warnings.